[Webkit-unassigned] [Bug 52200] Repaint SVG elements with filter instead of relayout where possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52200


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80061|review?                     |review+
               Flag|                            |




--- Comment #35 from Dirk Schulze <krit at webkit.org>  2011-01-25 06:58:42 PST ---
(From update of attachment 80061)
View in context: https://bugs.webkit.org/attachment.cgi?id=80061&action=review

r=me with two notes. great work!

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:340
> +static void recursiveClearResult(SVGFilterBuilder* builder, FilterEffect* effect)
> +{
> +    if (effect->hasResult()) {
> +        effect->clearResult();
> +
> +        HashSet<FilterEffect*>& effectReferences = builder->effectReferences(effect);
> +        HashSet<FilterEffect*>::iterator end = effectReferences.end();
> +        for (HashSet<FilterEffect*>::iterator it = effectReferences.begin(); it != end; ++it)
> +            recursiveClearResult(builder, *it);
> +    }
> +}

please reomve this before landing

> Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:105
> +    if (effect->hasResult()) {
> +        effect->clearResult();
> +
> +        HashSet<FilterEffect*>& effectReferences = this->effectReferences(effect);
> +        HashSet<FilterEffect*>::iterator end = effectReferences.end();
> +        for (HashSet<FilterEffect*>::iterator it = effectReferences.begin(); it != end; ++it)
> +            clearResultsRecursive(*it);
> +    }

make a early return here:
if (!effect->hasResult())
  return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.