[Webkit-unassigned] [Bug 47700] Make mime type lookup in File::create(path) thread-safe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47700





--- Comment #5 from Dai Mikurube <dmikurube at google.com>  2011-01-25 03:07:15 PST ---
(From update of attachment 79894)
View in context: https://bugs.webkit.org/attachment.cgi?id=79894&action=review

Hi Kinuko-san,

Thank you for your comments.

>> Source/WebCore/ChangeLog:20
>> +        * platform/MIMETypeRegistry.h:
> 
> It is generally encouraged to put short change summary (ideally) for each file, maybe the first two files may deserve short summary in this patch?

Exactly. I've added summary.

>> Source/WebCore/platform/android/TemporaryLinkStubs.cpp:310
>> +    ASSERT_NOT_REACHED();
> 
> This shouldn't compile if this happens right?
> 
> How about changing this to more generic check like:
> ASSERT(isMainThread());
> without guards, or only with ENABLE(WORKERS).

Changed as your advice. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.