[Webkit-unassigned] [Bug 45423] [Gtk] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45423





--- Comment #31 from Joone Hur <joone at kldp.org>  2011-01-25 02:28:25 PST ---
(In reply to comment #30)
> (From update of attachment 79136 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79136&action=review

Thanks, Martin for the review.
I updated the patch according to Martin's suggestions except the following:

> Source/WebCore/platform/graphics/gtk/TileGtk.cpp:47
> > +static const unsigned checkerColor1 = 0xff555555;
> > +static const unsigned checkerColor2 = 0xffaaaaaa; 
> Foreground and background, instead of 1 and 2 maybe? I'm not sure here.

I'm not sure which color is background color.

> > Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:155
> > +        virtual WebCore::IntRect visibleRectForTiledBackingStore() const;
> 
> Is it necessary to specify WebCore:: here?

Yes, using namespace statement is not allowed in header files

> 
> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:936
> > +                                                         _("Whether Tiled Backing Store should be enabled"),
> 
> Should Tiled Backing Store be capitalized?

Other setting names are also capitalized.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.