[Webkit-unassigned] [Bug 53016] [GTK] Crash in some pages containing flash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53016





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-25 00:38:15 PST ---
(In reply to comment #4)
> (From update of attachment 79930 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79930&action=review
> 
> Seems very reasonable to me!
> 
> > Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:113
> > +              "This probably reflects a bug in the flash plugin.\n"
> 
> Here it should probably either say "in a plugin" or "in the Adobe Flash plugin"

We only do it for flash, so I'll use "in the Adobe Flash plugin" :-)

> > Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:157
> > +    if (!g_strcmp0(baseName.get(), "libflashplayer.so")) {
> 
> g_str_equal here might be clearer, unless there's a possibility that basename may be null.
>
> > Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:160
> > +        // custom error handler to show a warning when a X error happenswithout aborting.
> 
> "happenswithout" -> happens without

Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.