[Webkit-unassigned] [Bug 53063] New: [NRWT] Remove TestArgs class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53063

           Summary: [NRWT] Remove TestArgs class
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hayato at chromium.org
                CC: eric at webkit.org, dpranke at chromium.org
            Blocks: 51091


It seems we can get rid of TestArgs class in new-run-webkit-tests. TestArgs class is defined in webkitpy/layout_tests/test_types/test_type_base.py.

TestArgs has fields of new_baseline, png_path, hash and wdiff, but only a new_baseline (and reset_results, which is wrongly assigned) field is used in actual code.

That class is used only in test_type::compare_output() as a parameter, but there TestArgs parameter can be replaced with 'options'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.