[Webkit-unassigned] [Bug 52983] Eliminate m_tagHistory pointer from CSSSelector
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 24 20:07:26 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=52983
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-01-24 20:07:26 PST ---
Attachment 80009 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSSelectorList.cpp:68: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]
Source/WebCore/css/CSSSelector.cpp:701: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSSelector.h:257: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Source/WebCore/css/CSSSelector.h:266: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/css/CSSParserValues.h:25: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 5 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list