[Webkit-unassigned] [Bug 52781] Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52781





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-01-24 17:24:21 PST ---
(From update of attachment 79951)
View in context: https://bugs.webkit.org/attachment.cgi?id=79951&action=review

>> Source/WebCore/editing/htmlediting.cpp:359
>> +    Vector<UChar> rebalanacedString;
> 
> s/rebalanacedString/rebalancedString
> 
> Also, why use a Vector<UChar> instead of  String like the old code did?

As far I checked, we can't modify each character in String directly (because multiple String instances may share single StringImpl).  i.e. String only has UChar operator[](unsigned index) const.

>> Source/WebCore/editing/htmlediting.h:239
>> +}
> 
> Nit: technically, this is not a function on String, os the comment is not correct.

Maybe I should change the comment to "Miscellaneous functions on Text"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.