[Webkit-unassigned] [Bug 52781] Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52781


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79951|review?                     |review+
               Flag|                            |




--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2011-01-24 16:54:42 PST ---
(From update of attachment 79951)
View in context: https://bugs.webkit.org/attachment.cgi?id=79951&action=review

> Source/WebCore/editing/htmlediting.cpp:359
> +    Vector<UChar> rebalanacedString;

s/rebalanacedString/rebalancedString

Also, why use a Vector<UChar> instead of  String like the old code did?

> Source/WebCore/editing/htmlediting.h:239
>  // Miscellaneous functions on String
> -    
> +inline bool isWhitespace(UChar c)
> +{
> +    return c == noBreakSpace || c == ' ' || c == '\n' || c == '\t';
> +}

Nit: technically, this is not a function on String, os the comment is not correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.