[Webkit-unassigned] [Bug 53004] Introduces DriverInput and DriverOutput classes and single_test_runner module.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53004





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2011-01-24 15:51:44 PST ---
(In reply to comment #2)
> (From update of attachment 79916 [details])
> Why would we want to move DriverOutput out of its own file and into a shared file?
>

Read the comments in the other bug ... the motivation is that TestInput and TestOutput are really pretty closely tied to the Driver class, and so it makes sense to rename them and move them to be next to the other class. I suggested that we actually move all of the Driver* classes out of base.py and into a driver.py (or some such file), but I could understand it if Ito-san didn't want to do that as part of this patch.

> This change is still qutie large.  The rename could be done first and easily rubber-stamped.
>

I actually prefer the fact that he's renaming things and moving them in a single patch, because it allows me to understand what's going on and review all the changes at once.

> I guess you're moving single-test-running logic from dump_render_tree_thread onto its own class?  That sounds like a very good idea.
>

Yes. Ironically, there's a large amount of overlap between single_test_runner and what will be the Worker class in the multiprocessing-safe patch (bug 52194), but that's what I get for taking so long to land the other one. More merging ahead :)

> Are you just moving code, or causing functional changes as well?

This change looks like it's just moving stuff around, and it looks good to me (though I can't R+ it).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.