[Webkit-unassigned] [Bug 52609] Add navigator.registerProtocolHandler behind a flag.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52609





--- Comment #14 from James Kozianski <koz at chromium.org>  2011-01-24 15:44:57 PST ---
(In reply to comment #12)
> (From update of attachment 79883 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79883&action=review
> 
> Seems fine. I noted a few nits below.
> 
> The biggest problem is that this patch doesn't seem to apply (see all of the purple ews statuses).

Hm, I think I needed to sync this patch. Hopefully it'll pass now.

> 
> > Source/WebCore/loader/EmptyClients.h:148
> > +        virtual void registerProtocolHandler(const String&, const String&, const String&, const String&) { }
> 
> indented too far.

Done.

> 
> > Source/WebKit/chromium/public/WebViewClient.h:327
> > +      const WebString& baseUrl, const WebString& url, const WebString& title);
> 
> Align with ( from previous line.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.