[Webkit-unassigned] [Bug 52839] [Qt][Symbian] Fix --minimal build

Mon Jan 24 10:50:42 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52839

--- Comment #9 from Yael <yael.aharon at nokia.com>  2011-01-24 10:50:42 PST ---
(In reply to comment #8)
> It would be good to avoid the special treatment for Symbian in build-webkit (and in webkitdirs.pm) especially that that the problem we're trying to solve is not specific to Symbian (e.g. I suspect that Windows minimal build would have the same problem).
> 
> I suggest to move setting USE_SYSTEM_MALLOC out from the Qt-specific make-system (WebKit.pri) and set it instead in common source-code (Platform.h like e.g. Android). By doing so build-webkit --minimal will no longer set USE_SYSTEM_MALLOC to 0. This would require adding a guard to TCSystemAlloc.cpp and including it for every Qt build.

Sorry, I did not realize that we check webkit.pri to figure out the defaults :(
I'll update the patch as you suggested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.