[Webkit-unassigned] [Bug 52200] Small filter primitive renderer improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52200





--- Comment #30 from Dirk Schulze <krit at webkit.org>  2011-01-24 01:38:24 PST ---
(In reply to comment #29)
> Ok I moved it after the apply(). Anyway, why it is "builded" instead of "built" ?
Oops! my fault :-) 

> > > Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:363
> > > +        repaintRectangle(filterData->absoluteDrawingRegion);
> > 
> > Interesting, but you couldn't check it on your mac?
> 
> Yeah, our mac has been recently updated and now pixel tests fail with 0.49% difference. Since the image is the same, I think the font was changed. After a clean build, I will check this again, but I don't expect this will change sincs non-filter related images are fail as well.
Likely that it is a problem with Nikos patch. :-(

> 
> > what if you have another element that is drawn on top of the filtered object? will it get repainted as well? (Unsure right now, a test case would help) Also isn't the parent renderer hierarchy RenderSVGResourceContainer-> RenderSVGHiddenContainer? Does it even affect any redrawings? I'd move this to another patch an invalidate like we did before. So you cann add more tests to check the correct behavior of the code.
> 
> It is ok for me, but how should the code look like? Keeping the functions, but not modify the DiffuseLighting? Or removing the code? Without repainting, the patch does nothing useful, so I think disabling the call in DiffuseLighting would make sense.
Unsure right now. But like I said before, we have to _mark_ the targets for repaint. And shouldn't call repaint directly. Anyway, make a complete invalidation now and try to find out how to repaint in a second patch ;-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.