[Webkit-unassigned] [Bug 47700] Make mime type lookup in File::create(path) thread-safe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47700





--- Comment #3 from Kinuko Yasuda <kinuko at chromium.org>  2011-01-23 23:11:47 PST ---
(From update of attachment 79894)
View in context: https://bugs.webkit.org/attachment.cgi?id=79894&action=review

Thanks for uploading this.  You'd want to wait for David's (or someone who knows very well) comments, but I put a few minor ones:

> Source/WebCore/ChangeLog:20
> +        * platform/MIMETypeRegistry.h:

It is generally encouraged to put short change summary (ideally) for each file, maybe the first two files may deserve short summary in this patch?

> Source/WebCore/platform/android/TemporaryLinkStubs.cpp:310
> +    ASSERT_NOT_REACHED();

This shouldn't compile if this happens right?

How about changing this to more generic check like:
ASSERT(isMainThread());
without guards, or only with ENABLE(WORKERS).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.