[Webkit-unassigned] [Bug 52890] IndexedDB corrupts data on disk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52890


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79751|review?                     |review+
               Flag|                            |




--- Comment #9 from Jeremy Orlow <jorlow at chromium.org>  2011-01-21 10:14:56 PST ---
(From update of attachment 79751)
View in context: https://bugs.webkit.org/attachment.cgi?id=79751&action=review

r=me

>> Source/WebCore/platform/sql/SQLiteStatement.cpp:388
>> +    if (size < 0 || size % sizeof(UChar) != 0)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]

The latter seems more like a sanity check...should we assert it's not true?  The following / is safe in that we won't read invalid memory.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:189
>  

get rid of second newline

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:198
> +            "INSERT INTO ObjectStoreData2 SELECT * FROM ObjectStoreData",

I worry about this....and think we should probably just blow away the data.  No one should have anything they really care about yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.