[Webkit-unassigned] [Bug 52200] Small filter primitive renderer improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52200





--- Comment #26 from Dirk Schulze <krit at webkit.org>  2011-01-21 09:53:49 PST ---
(In reply to comment #25)
> (In reply to comment #24)
> > (From update of attachment 79729 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=79729&action=review
> > 
> > > Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp:108
> > > +        primitiveAttributeChanged(attrName);
> > 
> > Did you miss my comment about calling the renderer directly here? https://bugs.webkit.org/show_bug.cgi?id=52200#c18
> 
> Hm? Perhaps I misunderstood you, but I added a
> 
> inline void primitiveAttributeChanged(const QualifiedName& attribute)
> {
> if (RenderObject* primitiveRenderer = renderer())
>     static_cast<RenderSVGResourceFilterPrimitive*>
>       (primitiveRenderer)->primitiveAttributeChanged(attribute);
> }
> 
> to the SVGFilterPrimitiveStandardAttributes.h. Would you prefer this in a different way?

Yes, like I wrote it in https://bugs.webkit.org/show_bug.cgi?id=52200#c18. This is the common way like  we do it for all elements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.