[Webkit-unassigned] [Bug 52890] IndexedDB corrupts data on disk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52890





--- Comment #7 from Andrei Popescu <andreip at google.com>  2011-01-21 09:41:39 PST ---
Thanks Hans!

(In reply to comment #4)
> (From update of attachment 79732 [details])
> Looks great. Some nits:
> 
> 
> > Source/WebCore/platform/sql/SQLiteStatement.cpp:190
> > +    return bindBlob(index, reinterpret_cast<const void*>(characters), text.length() * sizeof(UChar));
> 
> I believe static_cast is preferred. Sorry for not saying that earlier.
> 

Removed cast altogether.

> > Source/WebCore/platform/sql/SQLiteStatement.cpp:391
> > +    return String(reinterpret_cast<const UChar*>(blob), size / sizeof(UChar));
> 
> Ditto.
> 

Done.

> > Source/WebCore/platform/sql/SQLiteStatement.cpp:418
> >  }
> 
> Ditto.
> 

Done.

> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:134
> > +    return runCommands(sqliteDatabase, commands, 12);
> 
> Using '12' here seems a bit dangerous.. sizeof commands / sizeof commands[0] ?
> 

Done.

> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:144
> > +    return runCommands(sqliteDatabase, commands, 2);
> 
> Ditto for 2.
> 

Done.

> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:187
> > +        if (!runCommands(sqliteDatabase, commands, 15))
> 
> Ditto.
> 

Done.

> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:205
> > +        if (!runCommands(sqliteDatabase, commands, 7))
> 
> Ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.