[Webkit-unassigned] [Bug 52890] IndexedDB corrupts data on disk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52890





--- Comment #4 from Hans Wennborg <hans at chromium.org>  2011-01-21 09:10:25 PST ---
(From update of attachment 79732)
Looks great. Some nits:


> Source/WebCore/platform/sql/SQLiteStatement.cpp:190
> +    return bindBlob(index, reinterpret_cast<const void*>(characters), text.length() * sizeof(UChar));

I believe static_cast is preferred. Sorry for not saying that earlier.

> Source/WebCore/platform/sql/SQLiteStatement.cpp:391
> +    return String(reinterpret_cast<const UChar*>(blob), size / sizeof(UChar));

Ditto.

> Source/WebCore/platform/sql/SQLiteStatement.cpp:418
>  }

Ditto.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:134
> +    return runCommands(sqliteDatabase, commands, 12);

Using '12' here seems a bit dangerous.. sizeof commands / sizeof commands[0] ?

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:144
> +    return runCommands(sqliteDatabase, commands, 2);

Ditto for 2.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:187
> +        if (!runCommands(sqliteDatabase, commands, 15))

Ditto.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:205
> +        if (!runCommands(sqliteDatabase, commands, 7))

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.