[Webkit-unassigned] [Bug 50624] [GTK] Don't use a fixed size for search field icons

Fri Jan 21 09:09:18 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50624

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-21 09:09:18 PST ---
(In reply to comment #8)
> (In reply to comment #3)
> 
> > The largest possible size is GTK_ICON_SIZE_MENU so we are indeed doing so. We define GTK_ICON_SIZE_MENU as the max size in adjustSearchField methods, in most of the cases this is what we want and the returned pixbuf, which is cached by gtk, is valid, and only in a few cases we need to sacle it down.
> 
> Even so, wouldn't it be better to avoid any initial scaling at all by using (GtkIconSize)-1 explicitly?

I think we want to have a max icon size. Using GTK_ICON_SIZE_MENU we make sure the icon won't be bigger than 16 and we use the icon cache for most of the cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.