[Webkit-unassigned] [Bug 50624] [GTK] Don't use a fixed size for search field icons

Fri Jan 21 09:03:38 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50624

--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-01-21 09:03:38 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 79710 [details] [details])
> > I think we have a slight issue here which is that we don't modify the adjustSearchField*ButtonStyle methods, so WebCore doesn't really know how large the icon is. 
> 
> Yes, we modify the style in RenderThemeGtk::adjustSearchFieldCancelButtonStyle() and RenderThemeGtk::adjustSearchFieldResultsDecorationStyle()

In adjustSearchFieldCancelButtonStyle we simply set the icon to the size of GTK_ICON_SIZE_MENU. 

> fontsize is always the same for us, so it's not that different to what we currently do settings a fixed size. 

This isn't actually true. :) Try this:

<input type="search" id="target" results="5" value="Search me" style="font-size:50px; ">

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.