[Webkit-unassigned] [Bug 51587] [GTK] Remove mandatory Enchant dependency

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51587


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79706|review?                     |review-
               Flag|                            |




--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2011-01-21 01:06:12 PST ---
(From update of attachment 79706)
View in context: https://bugs.webkit.org/attachment.cgi?id=79706&action=review

Looks good, but I have a few style nits.

> ChangeLog:9
> +        Add enable-spell-checker option which decide whether to use spell
> +        checker. If disabled, WebKit/GTK+ will not use enchant library.

Should be "which decides" and WebKitGTK+.

> Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:32
> +#if ENABLE(SPELL_CHECKER)
>  #include <enchant.h>
> +#endif

Please split this out of the main block of includes now that it has an #ifdef around it.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:39
> +#if ENABLE(SPELL_CHECKER)
>  #include <enchant.h>
> +#endif

Ditto.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1267
> +        g_value_set_boolean(value, false);

You should use FALSE here explicitly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.