[Webkit-unassigned] [Bug 52802] SVG Pattern doesn't take preserveAspectRatio of references Pattern

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52802


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79637|review?                     |review+
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2011-01-20 13:13:54 PST ---
(From update of attachment 79637)
View in context: https://bugs.webkit.org/attachment.cgi?id=79637&action=review

Code and test look great, just tiny nitpicks, so r+ from me.

> Source/WebCore/ChangeLog:11
> +

Tiny nitpick, the wording could be better, could you rephrase a bit, "Modified PatternAttributes" is terse, and I don't think you should
put a comma after it for instance.

> LayoutTests/ChangeLog:9
> +

Better: Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.

> LayoutTests/svg/custom/pattern-referencing-preserve-aspect-ratio.svg:4
> +        x="-20" y="0" width="100" height="80" viewBox="0 0 20 40">

One space character too much in there :)

> LayoutTests/svg/custom/pattern-referencing-preserve-aspect-ratio.svg:17
> +</svg>

Indentation is not completely consistent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.