[Webkit-unassigned] [Bug 50624] [GTK] Don't use a fixed size for search field icons

Thu Jan 20 08:44:53 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50624

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-01-20 08:44:53 PST ---
(From update of attachment 79580)
View in context: https://bugs.webkit.org/attachment.cgi?id=79580&action=review

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:-261
> -    // We also add one pixel here to ensure that the y coordinate is rounded up for box heights
> -    // that are even, which looks in relation to the box text.

I believe kov asked me to add this comment specifically so we probably shouldn't delete it. It explains the "+ 1" below. It should say "looks good" though I think.

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:276
>      GRefPtr<GdkPixbuf> icon = getStockIcon(GTK_TYPE_ENTRY, GTK_STOCK_FIND,
>                                             gtkTextDirection(renderObject->style()->direction()),
>                                             gtkIconState(this, renderObject), GTK_ICON_SIZE_MENU);

Wouldn't it either make sense to either pass the actual size here or get the largest possible size and scale down?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.