[Webkit-unassigned] [Bug 52791] Buffer overrun in WebCore::InspectorBasicValue::writeJSON

Thu Jan 20 02:08:48 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52791

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79562|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2011-01-20 02:08:48 PST ---
(From update of attachment 79562)
View in context: https://bugs.webkit.org/attachment.cgi?id=79562&action=review

Thanks for the patch!  However every change requires a test and a ChangeLog.

> WebCore/inspector/InspectorValues.cpp:610
> +        DecimalNumber dv = m_doubleValue;

See the webkit style guide about variable naming.

> WebCore/inspector/InspectorValues.cpp:613
> +            // there is NOT ENOUGH ROOM, sorry. Use exponential format.

Comments should be sentences, beginning with a capital and ending with a period.

> WebCore/inspector/InspectorValues.cpp:615
> +                // Not even for this one? Sorry, you WON'T have a number.

I'm not sure this is a very useful comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.