[Webkit-unassigned] [Bug 5241] Space and tab characters "sent" by an input method give totally different results than typing them directly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5241





--- Comment #36 from MORITA Hajime <morrita at google.com>  2011-01-20 01:20:58 PST ---
Hi Ryosuke thanks much for r+ ;-0

(In reply to comment #34)
> (From update of attachment 79545 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79545&action=review
> 
> r=me provided you respond to the following two comments.
> 
> > LayoutTests/editing/inserting/insert-composition-whitespace.html:65
> > +test("div", " ", "\xA0");
> > +test("div", "  ", "\xA0\xA0");
> > +test("div", "   ", "\xA0\xA0\xA0");
Filed Bug 52781 for this.

> > Source/WebCore/editing/CompositeEditCommand.cpp:439
> > +    String text = static_cast<Text*>(node)->data();
It looks OK (I cannot find any extra spaces.) check-webkit-style should complain if any.

> 
> Nit: I think there's an extra space here before String.
> 
> > Source/WebCore/editing/CompositeEditCommand.cpp:446
> > +    rebalanceWhitespaceOnTextSubstring(static_cast<Text*>(node), position.deprecatedEditingOffset(), position.deprecatedEditingOffset());
> 
> We should not be calling deprecatedEditingOffset().  Because we've already checked that position is PositionIsOffsetInAnchor, we should be calling offsetInContainerNode() instead.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.