[Webkit-unassigned] [Bug 52733] [Qt] Fix Layering violation in MediaPlayerPrivateQt...

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52733


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79532|review?                     |review-
               Flag|                            |




--- Comment #4 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-01-19 19:47:32 PST ---
(From update of attachment 79532)
View in context: https://bugs.webkit.org/attachment.cgi?id=79532&action=review

r- as the ChangeLog needs to be fixed.

> Source/WebCore/ChangeLog:5
> +        [Qt] Fix Layering violation in MediaPlayerPrivateQt...

One dot please.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

OOPS would need to go - from http://webkit.org/coding/contributing.html

The "No new tests. (OOPS!)" line appears if prepare-ChangeLog did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.