[Webkit-unassigned] [Bug 52099] [Meta] Get rid of legacy editing position
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 19 17:43:29 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=52099
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jparent at google.com,
| |tony at chromium.org
--- Comment #1 from Ryosuke Niwa <rniwa at webkit.org> 2011-01-19 17:43:28 PST ---
Under this meta bug, we need to do:
- Stop instantiating legacy editing positions
- Remove calls to deprecatedEditingOffset()
- Remove improper calls to node()
The first two accomplishes the goal of this bug to eliminate the dependency on legacy editing positions.
The third comes from the fact, obtaining the anchor node of Position doesn't make much sense for new positions. When some editing code calls node() on some position, and checks if it's a text node or not. But what if the position was before or after a text node. The anchor node still be a text node but it's not inside. In fact, they're explicitly outside of the text node.
For this reason, we need to examine every and each call to node() and replace it by containerNode(), computeNodeBeforePosition(), computeNodeAfterPosition(), and anchorNode().
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list