[Webkit-unassigned] [Bug 52258] [GTK] Move toggle button rendering out of gtk2drawing.c

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 15:53:56 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52258





--- Comment #17 from Martin Robinson <mrobinson at webkit.org>  2011-01-19 15:53:56 PST ---
(In reply to comment #15)
> (From update of attachment 79435 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79435&action=review
> 
> Except for these spelling nits I see no issues with this patch, so r=me!
> 
> > Source/WebCore/ChangeLog:11
> > +        (WebCore::adjustRectForFocus): Added this function which inflate a rect based
> 
> inflates
> 
> > Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:189
> > +    // We do not call gtk_toggle_button_set_active here, because begin a series of animation
> 
> because begin? Are the series of animation timeouts started by gtk_toggle_button_set_active?

Thanks for the review. I've fixed the spelling errors and clarified these comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list