[Webkit-unassigned] [Bug 52742] New: Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52742

           Summary: Stop instantiating legacy editing positions in
                    FocusController::advanceFocusInDocumentOrder
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, justin.garcia at apple.com,
                    xan.lopez at gmail.com, msanchez at igalia.com,
                    mrobinson at webkit.org
            Blocks: 52099


We're currently in the process of removing all instantiations of legacy editing positions.  FocusController::advanceFocusInDocumentOrder currently instantiates two legacy editing positions in the line:
    if (caretBrowsing) {
        VisibleSelection newSelection(Position(node, 0), Position(node, 0), DOWNSTREAM);
        if (frame->selection()->shouldChangeSelection(newSelection))
            frame->selection()->setSelection(newSelection);
    }

They should be calling one of helper functions in Position.h or htmlediting.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.