[Webkit-unassigned] [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

Wed Jan 19 13:40:21 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=48459

Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77702|review-                     |review+
               Flag|                            |

--- Comment #17 from Dave Hyatt <hyatt at apple.com>  2011-01-19 13:40:20 PST ---
(From update of attachment 77702)
I guess I will tentatively r+ this, although I'm not sure what behavior you get with the @ added.  By not setting the orientation in SimpleFontData, you will end up with that code thinking the font doesn't support vertical, but if the built-in rendering just "does the right thing" then maybe that's ok.  I suspect it won't be sufficient though, especially when we get around to supporting text-orientation.  Still, if this gets the basics working then that seems pretty good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.