[Webkit-unassigned] [Bug 52622] Cache function offsets to speed up javascript parsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52622


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79410|review?                     |review-
               Flag|                            |




--- Comment #9 from Oliver Hunt <oliver at apple.com>  2011-01-19 12:51:26 PST ---
(From update of attachment 79410)
View in context: https://bugs.webkit.org/attachment.cgi?id=79410&action=review

r- due to comments

> Source/JavaScriptCore/parser/Lexer.h:88
> +            ASSERT(token.m_type == CLOSEBRACE);
> +            m_lineNumber = token.m_info.line;
> +            setOffset(token.m_info.endOffset);
> +            if (UNLIKELY(m_code == m_codeEnd))
> +                m_current = -1;
> +            m_delimited = true;
> +            m_lastToken = CLOSEBRACE;

this should be a call to setOffset, although you'll need to transfer 
if (UNLIKELY(m_code == m_codeEnd))
     m_current = -1;

To setOffset as well.

> Source/JavaScriptCore/parser/SourceProvider.h:76
> +

I think we really want SourceProviderCache to hang off of SourceProvider itself.  It will allow it to be devirtualised sensibly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.