[Webkit-unassigned] [Bug 52258] [GTK] Move toggle button rendering out of gtk2drawing.c

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 10:56:35 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52258


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79435|review?                     |review+
               Flag|                            |




--- Comment #15 from Gustavo Noronha (kov) <gns at gnome.org>  2011-01-19 10:56:35 PST ---
(From update of attachment 79435)
View in context: https://bugs.webkit.org/attachment.cgi?id=79435&action=review

Except for these spelling nits I see no issues with this patch, so r=me!

> Source/WebCore/ChangeLog:11
> +        (WebCore::adjustRectForFocus): Added this function which inflate a rect based

inflates

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:189
> +    // We do not call gtk_toggle_button_set_active here, because begin a series of animation

because begin? Are the series of animation timeouts started by gtk_toggle_button_set_active?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list