[Webkit-unassigned] [Bug 52702] [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52702


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




--- Comment #8 from Eric Seidel <eric at webkit.org>  2011-01-19 10:52:59 PST ---
(In reply to comment #5)
> The above test fail is not relevant to this patch.
> You can see the automatically generated bug from the commit-queue.
> https://bugs.webkit.org/show_bug.cgi?id=52709

Thanks.  The commit-queue runs the tests 3 times.  Twice with your patch and once w/o (if the first two runs failed).  In this case, the flaky test failed both times when you patch was applied, and then didn't fail when the tests ran w/o your patch.  So the queue had no choice but to (wrongly) assume it was your patch at fault.

Such is the cost of flaky tests!  Hopefully folks will continue to whittle down the number of flaky tests in the tree.

http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py#L214

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.