[Webkit-unassigned] [Bug 51364] Web Inspector: Remote Web Inspector for platform/mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51364





--- Comment #24 from Brian Weinstein <bweinstein at apple.com>  2011-01-19 10:50:03 PST ---
(From update of attachment 79340)
View in context: https://bugs.webkit.org/attachment.cgi?id=79340&action=review

Patch looks good.

> Source/WebKit/mac/WebInspector/WebInspectorServer.mm:184
> +        if (!it->second->allowsRemoteInspection())

If we're using it->second multiple times, is it worth it to pull it out into a local variable?

> Source/WebKit/mac/WebInspector/WebInspectorServerConnection.mm:395
> +        NSLog(@"WebInspectorServerConnection: WebView does not allow remote inspection.");

Is it useful to print any information about the WebView in this log?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.