[Webkit-unassigned] [Bug 51914] ElementRareData::m_shadowRoot should not be RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51914





--- Comment #20 from MORITA Hajime <morrita at google.com>  2011-01-18 23:51:15 PST ---
Levin, thank you for take a look!
I updated the patch which

- changed setShadowRoot() argument type from raw pointer to PassRefPtr, and 
- removed shadow node on Element dtor.

Note that this change calls removeShadowRoot() in Element dtor,
instead of deleting node in ElementRareData dtor.
This is because the ElementRareData dtor is called *after* the Elment dtor. It is called in the Node dtor. 
I think holding that half-dead pointer is potentially dangerous so clear it early.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.