[Webkit-unassigned] [Bug 5241] Space and tab characters "sent" by an input method give totally different results than typing them directly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5241





--- Comment #28 from MORITA Hajime <morrita at google.com>  2011-01-18 21:01:03 PST ---
Ryosuke, thank you for reviewing.

> > > How about containsOnlyWhitespace as in JavaScriptCore/wtf/text/StringImpl.h?
> > > 
> > Looks nice, So Replaced this with String::containsOnlyWhitespace()
> 
> Oh I didn't mean to replace it with String::containsOnlyWhitespace.  That function calls isASCIISpace and that function doesn't return true for a non-breaking space.  We should add a test for that.
I'm sorry but I don't think I understand what the point here is... What should happen?

> > > > +bool EventHandler::handleTextInputEvent(const String& text, Event* underlyingEvent, bool isLineBreak, bool isBackTab, bool isComposition)
> > > 
> > > I really don't like the fact this function takes 3! boolean arguments.  Would you mind cleaning that up in a separate patch?
> > Agreed and filed Bug 52608. I'll do it sometime soon.
> 
> Great.  We should probably fix the bug 52608 before fixing this bug though.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.