[Webkit-unassigned] [Bug 52608] Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of three bools

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52608


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79380|review?                     |review+
               Flag|                            |




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-01-18 18:47:37 PST ---
(From update of attachment 79380)
View in context: https://bugs.webkit.org/attachment.cgi?id=79380&action=review

> Source/WebCore/page/EventHandler.cpp:2670
> -    RefPtr<TextEvent> event = TextEvent::create(m_frame->domWindow(), text, TextEvent::selectInputType(isLineBreak, isBackTab));
> +    RefPtr<TextEvent> event = TextEvent::create(m_frame->domWindow(), text, inputType);

Only concern I have with this change is that we may permit inputType to be TextEventInputPaste or TextEventInputDrop here. Can we add an assertion that this can only be Keyboard, LineBreak, or BackTab?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.