[Webkit-unassigned] [Bug 51664] Refactoring: Extract RoundedIntRect class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51664





--- Comment #23 from MORITA Hajime <morrita at google.com>  2011-01-18 16:57:55 PST ---
Simon, Antonio, thank you for taking the review!

> > Source/WebCore/platform/graphics/GraphicsContext.cpp:546
> > +    path.addRoundedRect(rect.rect(), rect.radii().topLeft(), rect.radii().topRight(), rect.radii().bottomLeft(), rect.radii().bottomRight());
> 
> It would nice if Path::addRoundedRect get the "const RoundedIntRect&" as parameter, and extract the values from there.
> 
> Caller sites would look better, maybe.
I noticed that Path has only float-based APIs. So I think we should have RoundedFloatRect
for this purpose. I filed Bug 52685 and will take this.

> > Source/WebCore/platform/graphics/RoundedIntRect.h:87
> > +    void move(const IntSize size) { m_rect.move(size); }
> 
> const IntSize&
Will fix before land.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.