[Webkit-unassigned] [Bug 47194] Update ANGLE rev in Webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47194


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #10 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-01-18 15:28:48 PST ---
Attachment 79343 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ANGLE.xcodeproj/pr..." exit_code: 1

Last 3072 characters of output:
ANGLE/src/compiler/glslang_tab.cpp:4699:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:4706:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:4706:  glslang_parse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:20:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:20:  The parameter name "spec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:21:  The parameter name "resources" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:28:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:28:  The parameter name "spec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:29:  The parameter name "resources" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:32:  The parameter name "resources" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/Initialize.h:33:  The parameter name "extensionBehavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/libGLESv2/Fence.h:9:  #ifndef header guard has wrong style, please use: WTF_Fence_h  [build/header_guard] [5]
Source/ThirdParty/ANGLE/src/libGLESv2/Fence.h:16:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/Fence.h:19:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/Fence.h:22:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/libGLESv2/Fence.h:43:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.h:41:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.h:133:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.h:231:  Extra space for operator !   [whitespace/operators] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.h:234:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.h:267:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 3817 in 97 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.