[Webkit-unassigned] [Bug 52311] [chromium] Add command-line flag to enable composite to offscreen texture.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52311





--- Comment #32 from Vangelis Kokkevis <vangelis at chromium.org>  2011-01-18 09:54:08 PST ---
(In reply to comment #31)
> (In reply to comment #30)
> 
> I've found the problem - good news is I was mistaken, and it's not DRT's fault.
> 
> The problem stems from using 
> 
> useRenderSurface(0);
> 
> in the call to copyOffscreenTextureToDisplay(). This has the side effect of setting 
> 
> m_currentRenderSurface = renderSurface; // = 0
> 
> which then causes a null pointer dereference in when we call m_defaultRenderSurface->draw(), since it calls setScissorToRect(), which attempts
> 
> int scissorX = scissorRect.x() - m_currentRenderSurface->m_contentRect.x();
> 
> Should I modify setScissorToRect() to handle this case (use rootLayer rect instead?), or stop using useRenderSurface(0)?

Oops.  Good catch.  Modifying setScissorRect is reasonable as the method needs to be able to deal with drawing directly to the window.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.