[Webkit-unassigned] [Bug 52327] [GTK] Move text field painting out of gtk2drawing.c

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52327


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78826|review?                     |review+
               Flag|                            |




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2011-01-18 04:57:00 PST ---
(From update of attachment 78826)
View in context: https://bugs.webkit.org/attachment.cgi?id=78826&action=review

Other than improving the comment, I think this patch is good to go!

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:372
> +    widgetContext.gtkPaintShadow(textFieldRect, widget, GTK_STATE_NORMAL, GTK_SHADOW_IN, "entry");

I'm not sure I understand what this comment says to be honest. So GTK+ relies on having the unfocused entry previously rendered, and then renders a smaller but complete text entry on top of it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.