[Webkit-unassigned] [Bug 40833] [GTK] The GTK+ EventSender needs support for beginDragWithFiles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40833


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78296|review?                     |review+
               Flag|                            |




--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2011-01-18 04:38:59 PST ---
(From update of attachment 78296)
View in context: https://bugs.webkit.org/attachment.cgi?id=78296&action=review

Looks good!

> Tools/DumpRenderTree/gtk/EventSender.cpp:439
> +    GFile* testFile = g_file_new_for_uri(mainFrameURI);

We should be able to use GRefPtr here, since we're using GOwnPtr for the chars =)?

> Tools/DumpRenderTree/gtk/EventSender.cpp:452
> +        parentDirectory = g_file_new_for_path(currentDirectory.get());

You're leaking the parentDirectory returned by g_file_get_parent() here. Perhaps fix this just by using GRefPtr on it as well =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.