[Webkit-unassigned] [Bug 51914] ElementRareData::m_shadowRoot should not be RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51914





--- Comment #14 from MORITA Hajime <morrita at google.com>  2011-01-18 00:35:55 PST ---
note from irc:
> morrita: Your patch looks wrong to me. You got rid of RefPtr but you are using leakPtr which mean you are putting a ref counted object into taht pointer.
> morrita: Then it doesn't do adoptRef (when putting out the pointer) but if you were doing that then why get rid of teh RefPtr at all because you'd be doing the same thing but all by hand.
> morrita: Also having a method take a PassRefPtr when it doesn't take ownership seems very wrong.

----
So Dimitri is right.  Element::setShadowRoot() should accept raw pointer of Node. 
The revised patch will come shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.