[Webkit-unassigned] [Bug 52370] Style sharing optimization no longer works on major web sites

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52370


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79067|review?                     |review+
               Flag|                            |




--- Comment #13 from Dave Hyatt <hyatt at apple.com>  2011-01-17 13:33:45 PST ---
(From update of attachment 79067)
View in context: https://bugs.webkit.org/attachment.cgi?id=79067&action=review

r=me

Great patch.

> Source/WebCore/css/CSSStyleSelector.cpp:574
> +    // Collect all ids and rules using silbling selectors (:first-child and similar)

Typo.  "silbling" should be "sibling"

> Source/WebCore/css/CSSStyleSelector.cpp:2998
> +static inline bool isSiblingSelector(CSSSelector* selector)

I would just make this a member function of CSSSelector.  I can see us using it elsewhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.