[Webkit-unassigned] [Bug 50050] [Qt] plugins/keyboard-events.html fails after r72717

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50050


Robert Hogan <robert at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
                 CC|                            |ossy at webkit.org




--- Comment #12 from Robert Hogan <robert at webkit.org>  2011-01-17 12:17:02 PST ---
I had to re-skip plugins/keyboard-events.html because it failed on the buildbot.

The change that broke this originally for Qt is http://trac.webkit.org/changeset/72717

I think the reason my patch failed is as follows, and am hoping Martin might be amenable to going back to using the keysym for this event.

In order to get the keycode of the keyboard event, we have to do:

xEvent->xkey.keycode = XKeysymToKeycode(QX11Info::display(), XStringToKeysym(keyText.toUtf8().constData()));

At first I thought it failed on the buildbot because it was headless, but the tests are run under xvfb so that was only half-right. The real reason, it seems to me, is because xvfb doesn't have a keyboard, so XKeysymToKeycode will always fail. (See http://lists.apple.com/archives/x11-users/2009/Apr/msg00016.html for an example of this elsewhere).

Since there's no keyboard mapping available to xvfb it can't determine the keycode. I recreated the problem in Ossy's 'QtWebKit Builder and Tester VM (Q-BAT VM)'.

I'm going to drop to a terminal session on this machine with no x server running so see if I can recreate it here too. I'll come back with my results but it looks as if using the keycodes won't work for us running our buildbot under xvfb.

Looking at the output from the other buildbots I think qt may be alone running the layout tests under xvfb. Who would be able to confirm that do you know?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.