[Webkit-unassigned] [Bug 51664] Refactoring: Extract RoundedIntRect class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 10:19:44 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51664


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79127|review?                     |review+
               Flag|                            |




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-01-17 10:19:43 PST ---
(From update of attachment 79127)
View in context: https://bugs.webkit.org/attachment.cgi?id=79127&action=review

> Source/WebCore/platform/graphics/RoundedIntRect.h:48
> +        Radii(const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight)
> +            : m_topLeft(topLeft)
> +            , m_topRight(topRight)
> +            , m_bottomLeft(bottomLeft)
> +            , m_bottomRight(bottomRight)
> +        {
> +        }
> +
> +        void setTopLeft(const IntSize& size) { m_topLeft = size; }

I think you should include x(), y(), width(), height(), right() and bottom() here just as IntRect has.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list