[Webkit-unassigned] [Bug 50050] [Qt] plugins/keyboard-events.html fails after r72717

Sun Jan 16 12:34:23 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50050

Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79106|review?                     |review+
               Flag|                            |

--- Comment #6 from Andreas Kling <kling at webkit.org>  2011-01-16 12:34:23 PST ---
(From update of attachment 79106)
View in context: https://bugs.webkit.org/attachment.cgi?id=79106&action=review

LGTM, thanks for attending to this!

> Source/WebCore/plugins/qt/PluginViewQt.cpp:426
> +        QString chr = qKeyEvent->text().left(1);

Nit: We don't abbreviate variable names in WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.