[Webkit-unassigned] [Bug 52380] Lazily generate and store logical ordering of InlineBoxes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52380





--- Comment #13 from Antti Koivisto <koivisto at iki.fi>  2011-01-15 09:20:21 PST ---
If these caches are actually used the memory will balloon far beyond the already bad pointer-per-root-inline-box. All those pointer vectors (in this patch each cache is at least 128 bytes even if it has just one item, though that could be optimized) will add up. On the other hand if the caches are not used then all those null pointers are wasted space. 

A better approach would be to have a non-member cache. Search for "RareData" in WebCore to find a number of examples. You would still need to take care that it won't bloat too much even if someone touches all nodes in a huge document.

First thing to do however is to make sure you are fixing a real problem. You should do profiling before writing performance patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.