[Webkit-unassigned] [Bug 51364] Web Inspector: Remote Web Inspector for platform/mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 19:14:29 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51364





--- Comment #18 from Matt Lilek (pewtermoose) <mlilek at apple.com>  2011-01-14 19:14:27 PST ---
(In reply to comment #3)
> Created an attachment (id=77066)
 --> (https://bugs.webkit.org/attachment.cgi?id=77066&action=review) [details]
> [PATCH] Part 3: Add WebInspectorServer, Connection, and Remote Channel
> 
> This is the bulk of the work. It adds the Server, Connection, and Channel classes.
> It modifies the Client to work with a remote connection, but nothing is turned
> on in this patch. This is just the support.

+        // Stringify the data.
+        CFDataRef frameData = CFDataCreateWithBytesNoCopy(kCFAllocatorDefault, frameStart + 1, frameRange.length - 2, kCFAllocatorNull);
+        NSString *decodedString = [[NSString alloc] initWithData:(NSData *)frameData encoding:NSUTF8StringEncoding];

Where is decodedString released?

I also believe ServerListing has to be prefixed to avoid class name conflicts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list