[Webkit-unassigned] [Bug 52370] Style sharing optimization no longer works on major web sites

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52370


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-01-14 15:06:29 PST ---

> > Source/WebCore/css/CSSStyleSelector.cpp:3011
> > +    return relation == CSSSelector::DirectAdjacent
> > +        || relation == CSSSelector::IndirectAdjacent
> > +        || type == CSSSelector::PseudoEmpty
> > +        || type == CSSSelector::PseudoFirstChild
> > +        || type == CSSSelector::PseudoLastChild
> > +        || type == CSSSelector::PseudoOnlyChild
> > +        || type == CSSSelector::PseudoOnlyOfType
> > +        || type == CSSSelector::PseudoNthChild
> > +        || type == CSSSelector::PseudoNthOfType
> > +        || type == CSSSelector::PseudoNthLastChild
> > +        || type == CSSSelector::PseudoNthLastOfType;
> > +}
> 
> Style rules are to put || at the end of the previous line.

>From the style guide:
"5. Boolean expressions at the same nesting level that span multiple lines should have their operators on the left side of the line instead of the right side."

It seems that the code is correct according to the style guide

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.