[Webkit-unassigned] [Bug 45186] Use the Windows thread pool instead of an extra thread for FastMalloc scavenging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45186


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78983|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #15 from Adam Roben (aroben) <aroben at apple.com>  2011-01-14 12:55:06 PST ---
(From update of attachment 78983)
View in context: https://bugs.webkit.org/attachment.cgi?id=78983&action=review

> Source/JavaScriptCore/wtf/FastMalloc.cpp:1566
> +    // We need to use WT_EXECUTEONLYONCE here and reschedule the timer, because
> +    // Windows will fire the timer event even when the function is already running.

Passing 0 for the repeat duration should be enough to make the timer fire only once. If you pass WT_EXECUTEDEFAULT, are you then able to use ChangeTimerQueueTimer to reuse the same timer? If that still doesn't work, I think it's worth adding a comment in rescheduleScavenger and/or suspendScavenger that explains why we have to delete and recreate the timer.

> Source/JavaScriptCore/wtf/FastMalloc.cpp:2463
> +    if (shouldScavenge()) {
> +        suspendScavenger();
> +        return;
> +    }

I think you're missing a ! in there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.